fix(core): prevent cleared fields from re-defaulting when another field is cleared (#5125 regression)#5138
Open
yap-house wants to merge 2 commits into
Open
fix(core): prevent cleared fields from re-defaulting when another field is cleared (#5125 regression)#5138yap-house wants to merge 2 commits into
yap-house wants to merge 2 commits into
Conversation
…ld is cleared (rjsf-team#5125 regression)
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
This fixes a regression introduced in #5136.
After clearing field A, clearing field B caused field A to be re-populated with its schema default.
The fix uses
_set(formData, path, undefined)instead of_unsetto keep the cleared key present in state, preventingmergeDefaultsWithFormDatafrom re-applying the default. A new private helperomitUndefinedLeaves()stripsundefined-valued keys before AJV validation to preserve the #4518 fix.fixes #5125
Checklist
pnpm exec nx run-many --target=build --exclude=@rjsf/docs && pnpm run test:updateto update snapshots, if needed.