Skip to content

Conversation

@MatthewCollinsNZ
Copy link
Contributor

In order to control the row selection behavior of the editable grid, we need to have this prop, this changes behavior from the default multi select by holding control, to multi select with mouse click.

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

New Feature Submission:

  • Does your submission pass the tests?
  • Have you linted your code locally prior to submission?

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 20, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing MatthewCollinsNZ:Adding-Row-Selection-Mode-To-Editable-Table (d4e372c) with main (2545378)

Summary

✅ 8 untouched benchmarks

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 20, 2026

Greptile Overview

Greptile Summary

Added row_selection_mode property to the DataEditor component to control row selection behavior in the editable grid.

  • Enables control over row marker selection behavior with two modes: "auto" (adapts to touch/mouse input) and "multi" (always acts as if Ctrl is pressed)
  • Property follows the existing pattern for selection-related properties in the component
  • No breaking changes or logic modifications

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The change adds a single, simple property declaration that follows existing patterns in the codebase, with no logic changes or breaking modifications
  • No files require special attention

Sequence Diagram

sequenceDiagram
    participant User
    participant DataEditor
    participant GlideDataGrid
    
    User->>DataEditor: Set row_selection_mode prop
    Note over DataEditor: row_selection_mode: "auto" | "multi"
    DataEditor->>GlideDataGrid: Pass row_selection_mode to underlying library
    
    alt row_selection_mode = "auto"
        User->>GlideDataGrid: Click row marker
        GlideDataGrid->>GlideDataGrid: Adapt behavior to touch/mouse
        Note over GlideDataGrid: Single select on click,<br/>multi-select with Ctrl
    else row_selection_mode = "multi"
        User->>GlideDataGrid: Click row marker
        GlideDataGrid->>GlideDataGrid: Act as if Ctrl is pressed
        Note over GlideDataGrid: Always multi-select
    end
    
    GlideDataGrid->>DataEditor: Update selection state
    DataEditor->>User: Reflect updated row selection
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant