producer_swarm: Add scale factor to wait#30963
Open
StephanDollberg wants to merge 1 commit into
Open
Conversation
Depending on how many brokers there are the initial wait can be slower (as seen on GCP v3 T9). Allow scaling the wait factor.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a configurable scale factor to ProducerSwarm.wait_for_all_started() so tests can extend the initial “all producers started” wait on larger broker counts (e.g., higher-tier cloud clusters), and wires that scaling into the OMB validation test.
Changes:
- Extend
ProducerSwarm.wait_for_all_started()with atimeout_scaleparameter and apply it to the computed timeout. - In
omb_validation_test, scale the swarm-start wait based on broker count and update an explanatory comment.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
tests/rptest/services/producer_swarm.py |
Adds a timeout_scale parameter to scale the startup wait timeout for producer swarms. |
tests/rptest/redpanda_cloud_tests/omb_validation_test.py |
Applies broker-count-based scaling when waiting for swarms to start; clarifies warm-up rate comment. |
Comment on lines
148
to
+149
| timeout_s = 30 + 3 * ceil(self._producers * self.CLIENT_SPAWN_WAIT_MS / 1000) | ||
| timeout_s = int(timeout_s * timeout_scale) |
Comment on lines
431
to
+434
| for s in swarm: | ||
| # wait for the swarm to report that all producers have started (sent at least 1 message) | ||
| s.wait_for_all_started() | ||
| broker_scale_factor = max(1, self.num_brokers / 6) | ||
| s.wait_for_all_started(timeout_scale=broker_scale_factor) |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depending on how many brokers there are the initial wait can be slower (as seen on GCP v3 T9).
Allow scaling the wait factor.
Backports Required
Release Notes