Skip to content

Conversation

@vbotbuildovich
Copy link
Contributor

This PR auto-updates the acceptance tests we use as examples in our Kubernetes docs.

@vbotbuildovich vbotbuildovich requested a review from a team as a code owner December 12, 2025 15:39
@netlify
Copy link

netlify bot commented Dec 12, 2025

Deploy Preview for redpanda-docs-preview ready!

Name Link
🔨 Latest commit 04e0f77
🔍 Latest deploy log https://app.netlify.com/projects/redpanda-docs-preview/deploys/693c371792b285000806f03d
😎 Deploy Preview https://deploy-preview-1516--redpanda-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 12, 2025

📝 Walkthrough

Walkthrough

The change modifies a test scenario in the Kubernetes decommissioning feature file. The prune step specification has been refined to target the node removed in the preceding step, replacing the previous behavior of pruning any node in NotReady status. This narrows the test expectation to verify more specific recovery semantics following node removal.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Single test file modification with narrowed pruning scope
  • Reviewer should verify that the specific node targeting aligns with intended decommissioning recovery behavior
  • Confirm the change doesn't conflict with other test scenarios or documented behavior

Possibly related PRs

  • auto-docs: Update K8s acceptance tests #1445: Adds a scenario that prunes NotReady nodes in the decommissioning feature; this PR narrows that pruning criterion to target the specific removed node, refining the test behavior established in the related PR.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description is minimal and lacks required sections from the template including JIRA ticket reference, review deadline, page previews, and check categories. Add required template sections: resolve JIRA ticket link, review deadline, Netlify page previews, and specify which check category applies (e.g., Support Follow-up).
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly indicates the PR updates Kubernetes acceptance tests used as examples in docs, which aligns with the file change summary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch update-acceptance-tests

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between e7f9623 and 04e0f77.

📒 Files selected for processing (1)
  • modules/manage/examples/kubernetes/decommissioning.feature (1 hunks)
🔇 Additional comments (1)
modules/manage/examples/kubernetes/decommissioning.feature (1)

11-11: Ensure the new “prune … removed in previous step” step is actually bound + deterministic.

This step now depends on state captured from prior steps; please verify the step definition exists and reliably identifies which node was removed (e.g., by name/UID recorded during the shutdown/remove action), otherwise this can become flaky/ambiguous (“removed” vs merely NotReady). Consider tightening the wording to “prune the Kubernetes node removed…” if the framework supports it.

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Comment @coderabbitai help to get the list of available commands and usage tips.

@JakeSCahill JakeSCahill merged commit ceb8177 into main Dec 16, 2025
7 checks passed
@JakeSCahill JakeSCahill deleted the update-acceptance-tests branch December 16, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants