fix(accessibility): Derive accessibilityTraits from role and state (#57515)#57516
Open
cgoldsby wants to merge 1 commit into
Open
fix(accessibility): Derive accessibilityTraits from role and state (#57515)#57516cgoldsby wants to merge 1 commit into
cgoldsby wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the two independent writers on
accessibilityTraits(one in C++ for role, one in ObjC for state) with a singlederiveAccessibilityTraits()helper that rebuilds the full mask fromNoneeach commit.On recycled Fabric views, the ObjC writer's diff guard can skip when the stale
_propsmatch the new props, leavingSelectedandNotEnabledtraits stale.Fixes #57515
Changelog:
[IOS] [FIXED] - Derive
accessibilityTraitsfrom role and state in a single writer soSelectedandNotEnabledtraits are not lost on recycled Fabric viewsTest Plan:
Reproducer repo: https://github.com/cgoldsby/rn-accessibility-traits-bug ([steps](https://github.com/cgoldsby/rn-accessibility-traits-bug#steps-to-reproduce-bug))
role="button"to no roleBefore fix:
Selectedtrait is missingAfter fix:
Selectedtrait persists through the role change