Consolidate package checks into one Jest test

.eslintrc.js

@@ -61,12 +61,6 @@ module.exports = {
       files: ['package.json'],
       parser: 'jsonc-eslint-parser',
     },
-    {
-      files: ['package.json'],
-      rules: {
-        '@react-native/monorepo/react-native-manifest': 'error',
-      },
-    },
     {
       files: ['flow-typed/**/*.js', 'packages/react-native/flow/**/*'],
       rules: {

.github/workflows/test-all.yml

@@ -453,9 +453,6 @@ jobs:
         uses: ./.github/actions/setup-node
       - name: Install dependencies
         uses: ./.github/actions/yarn-install
-      - name: Lint file structure
-        shell: bash
-        run: ./.github/workflow-scripts/lint_files.sh
       - name: Run shellcheck
         shell: bash
         run: ./.github/workflow-scripts/analyze_scripts.sh

private/eslint-plugin-monorepo/index.js

@@ -15,7 +15,6 @@ exports.rules = {
   'no-react-named-type-imports': require('./rules/no-react-named-type-imports'),
   'no-react-native-imports': require('./rules/no-react-native-imports'),
   'no-react-node-imports': require('./rules/no-react-node-imports'),
-  'react-native-manifest': require('./rules/react-native-manifest'),
   'require-extends-error': require('./rules/require-extends-error'),
   'sort-imports': require('./rules/sort-imports'),
   'valid-flow-typed-signature': require('./rules/valid-flow-typed-signature'),

scripts/monorepo-tests/__tests__/check-packages-test.js

@@ -0,0 +1,42 @@
+/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ * @flow strict-local
+ * @format
+ */
+
+import {REPO_ROOT} from '../../shared/consts';
+import {
+  getReactNativePackage,
+  getWorkspaceRoot,
+} from '../../shared/monorepoUtils';
+import {globSync} from 'tinyglobby';
+
+describe('package manifests', () => {
+  test('the workspace root must not declare runtime dependencies', async () => {
+    const {packageJson} = await getWorkspaceRoot();
+    expect(packageJson).not.toHaveProperty('dependencies');
+  });
+
+  test('the react-native package must not declare devDependencies', async () => {
+    const {packageJson} = await getReactNativePackage();
+    expect(packageJson).not.toHaveProperty('devDependencies');
+  });
+});
+
+describe('package file structure', () => {
+  test('packages must not contain .npmignore files', () => {
+    // Publishing must be controlled via the package.json "files" field, which is
+    // easier to audit and does not silently expand what gets shipped to npm.
+    const npmignoreFiles = globSync('{packages,private}/**/.npmignore', {
+      cwd: REPO_ROOT,
+      dot: true,
+      ignore: ['**/node_modules/**'],
+    });
+
+    expect(npmignoreFiles).toEqual([]);
+  });
+});