Consolidate package checks into one Jest test#57509
Closed
huntie wants to merge 1 commit into
Closed
Conversation
Summary: Simplify/unify various mechanisms for the monorepo's package invariants. These checks were previously scattered: - `private/monorepo-tests` package (manifest field checks) - `.github/workflow-scripts/lint_files.sh` (`.npmignore` ban) - `react-native/eslint-plugin-monorepo` (manifest field checks — duplicated) This folds everything into `scripts/monorepo-tests/__tests__/check-packages-test.js`. A plain Jest test is the most extensible home for future checks. Changelog: [Internal] Differential Revision: D111471313
meta-cla
Bot
added
the
CLA Signed
cortinico
approved these changes
Jul 10, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
|
This pull request has been merged in 0ed6c56. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Simplify/unify various mechanisms for the monorepo's package invariants.
These checks were previously scattered:
private/monorepo-testspackage (manifest field checks).github/workflow-scripts/lint_files.sh(.npmignoreban)react-native/eslint-plugin-monorepo(manifest field checks — duplicated)This folds everything into
scripts/monorepo-tests/__tests__/check-packages-test.js. A plain Jest test is the most extensible home for future checks.Changelog: [Internal]
Differential Revision: D111471313