This repository was archived by the owner on Feb 21, 2020. It is now read-only.
Allow local values when constructing the injector. #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Injector.sub() has used this form for a while, but it is useful when a sub injector is not needed.
groner
changed the title
Owner
There was a problem hiding this comment.
These changes should go into README.rst.in given the project's custom doc builder.
Collaborator
Author
There was a problem hiding this comment.
This is the built doc generated from the jeni.Injector docstring.
Owner
There was a problem hiding this comment.
Oh right, I see that now. Reading the diff view isn't always optimal.
Owner
|
+1 overall. This is a useful patch. Comments on docs are on the diff. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the change proposed in #17.
@rduplain