chore: acknowledge deprecated API usage#1781
Open
AmanGIT07 wants to merge 1 commit into
Open
Conversation
Annotate the deliberate uses of deprecated APIs: handler fallbacks that honor old request fields, the deprecated config flag, seed and e2e tooling, readers of the deprecated response fields, and the New Relic v2 imports. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (12)
📝 WalkthroughSummary by CodeRabbit
WalkthroughChangesStaticcheck suppressions
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Coverage Report for CI Build 29822862055Coverage remained the same at 46.201%Details
Uncovered Changes
Coverage Regressions3 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Annotate every remaining use of a deprecated API with
//nolint:staticcheck. Each use is deliberate; none can be removed today without breaking a compatibility contract or losing information.Changes
Since, subscription flatPlan/Immediate, permission create/updatenamespace/name, federated check split object fieldscmd/serve.go: the deprecatedFullyConsistentconfig flag is still honored for existing configscmd/seed.go: seed data deliberately sends the deprecated permission body shapeinternal/reconcileandcmd/permission.go: read the deprecatedNamespace/Nameresponse fields — the replacementKeyround-trips lossily (single-segment namespaces gain a/defaultsuffix, dotted names split wrong), so the deprecated fields are the only faithful representation todayUpdateBillingAccountLimitsRPC and two assertions on the deprecated response fieldspkg/db,internal/store/spicedb: the deprecated New Relic go-agent v2 imports; the v3 migration is a separate piece of workTest Plan
Issue 1782 tracks this so we remove the deprecated usage