Skip to content

chore: acknowledge deprecated API usage#1781

Open
AmanGIT07 wants to merge 1 commit into
mainfrom
chore/acknowledge-deprecations
Open

chore: acknowledge deprecated API usage#1781
AmanGIT07 wants to merge 1 commit into
mainfrom
chore/acknowledge-deprecations

Conversation

@AmanGIT07

@AmanGIT07 AmanGIT07 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Summary

Annotate every remaining use of a deprecated API with //nolint:staticcheck. Each use is deliberate; none can be removed today without breaking a compatibility contract or losing information.

Changes

  • Handler fallbacks that honor deprecated request fields for old clients: billing usage Since, subscription flat Plan/Immediate, permission create/update namespace/name, federated check split object fields
  • cmd/serve.go: the deprecated FullyConsistent config flag is still honored for existing configs
  • cmd/seed.go: seed data deliberately sends the deprecated permission body shape
  • internal/reconcile and cmd/permission.go: read the deprecated Namespace/Name response fields — the replacement Key round-trips lossily (single-segment namespaces gain a /default suffix, dotted names split wrong), so the deprecated fields are the only faithful representation today
  • e2e: two uses of the deprecated UpdateBillingAccountLimits RPC and two assertions on the deprecated response fields
  • pkg/db, internal/store/spicedb: the deprecated New Relic go-agent v2 imports; the v3 migration is a separate piece of work

Test Plan

Issue 1782 tracks this so we remove the deprecated usage

Annotate the deliberate uses of deprecated APIs: handler fallbacks that
honor old request fields, the deprecated config flag, seed and e2e
tooling, readers of the deprecated response fields, and the New Relic
v2 imports.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@vercel

vercel Bot commented Jul 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
frontier Ready Ready Preview, Comment Jul 21, 2026 10:36am

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ad8b732c-bede-4a74-9a76-9f1089458af5

📥 Commits

Reviewing files that changed from the base of the PR and between d34ae82 and 0de547b.

📒 Files selected for processing (12)
  • cmd/permission.go
  • cmd/seed.go
  • cmd/serve.go
  • internal/api/v1beta1connect/billing_subscription.go
  • internal/api/v1beta1connect/billing_usage.go
  • internal/api/v1beta1connect/permission.go
  • internal/api/v1beta1connect/permission_check.go
  • internal/reconcile/permission_reconciler.go
  • internal/store/spicedb/relation_repository.go
  • pkg/db/db.go
  • test/e2e/regression/billing_test.go
  • test/e2e/regression/service_registration_test.go

📝 Walkthrough

Summary by CodeRabbit

  • Chores

    • Updated static analysis suppressions across command, API, storage, and reconciliation components.
    • Adjusted import annotations to address static analysis findings without changing runtime behavior.
  • Tests

    • Added targeted static analysis suppressions to billing and service registration regression tests.
    • No test coverage, assertions, or end-user functionality changed.

Walkthrough

Changes

Staticcheck suppressions

Layer / File(s) Summary
Application path suppressions
cmd/*.go, internal/api/v1beta1connect/*.go, internal/reconcile/permission_reconciler.go
Targeted //nolint:staticcheck directives were added across command, billing, permission, checking, and reconciliation paths.
New Relic import suppressions
internal/store/spicedb/relation_repository.go, pkg/db/db.go
New Relic imports were annotated with //nolint:staticcheck.
Regression test suppressions
test/e2e/regression/billing_test.go, test/e2e/regression/service_registration_test.go
Targeted suppressions were added around existing billing and service-registration test operations.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested reviewers: whoabhisheksah

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 29822862055

Coverage remained the same at 46.201%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: 5 uncovered changes across 4 files (4 of 9 lines covered, 44.44%).
  • 3 coverage regressions across 1 file.

Uncovered Changes

File Changed Covered %
cmd/permission.go 2 0 0.0%
cmd/seed.go 1 0 0.0%
cmd/serve.go 1 0 0.0%
internal/api/v1beta1connect/billing_subscription.go 1 0 0.0%
Total (7 files) 9 4 44.44%

Coverage Regressions

3 previously-covered lines in 1 file lost coverage.

File Lines Losing Coverage Coverage
internal/reconcile/permission_reconciler.go 3 75.51%

Coverage Stats

Coverage Status
Relevant Lines: 38443
Covered Lines: 17761
Line Coverage: 46.2%
Coverage Strength: 13.36 hits per line

💛 - Coveralls

@AmanGIT07
AmanGIT07 requested a review from rohilsurana July 22, 2026 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants