chore: acknowledge unactionable errors explicitly#1773
Open
AmanGIT07 wants to merge 1 commit into
Open
Conversation
Blank-assign or nolint-mark seven ignored error returns where nothing useful can be done: New Relic segment ends, HTTP response encodes, the deferred rollback safety net, and the e2e teardown signal. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughSummary by CodeRabbit
WalkthroughLint suppressions and explicit blank-identifier assignments were added to deferred cleanup calls, JSON encoding calls, and process signaling. Runtime behavior and public interfaces remain unchanged. ChangesLint compliance cleanup
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Coverage Report for CI Build 29580488960Coverage remained the same at 46.11%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Seven call sites ignore an error that is either expected or has no useful handling. Mark each with an explicit blank assignment or a
nolintcomment so the intent is visible.Changes
internal/store/spicedb/relation_repository.go:// nolinton the three deferred New Relicnr.End()calls (a failure only loses one timing data point; keeps the defers as single statements)pkg/server/server.go:_ =on the two responseEncodecalls (fails only when the client already disconnected)internal/store/postgres/audit_record_repository.go: wrap the deferredtx.Rollback()safety net (returnsErrTxDoneafter a finished transaction by design)test/e2e/testbench/testbench.go:_ =on the teardown self-interrupt signalTechnical Details
No behavior change; the compiled code is identical.
Test Plan
go test ./pkg/server/ ./internal/store/postgres/passesSQL Safety (if your PR touches
*_repository.goorgoqu.*)?placeholders,goqu.Ex{}, orgoqu.Record{}— neverfmt.Sprintfor+building a query that gets executed.ToSQL()callers capture and forward params (query, params, err := stmt.ToSQL(); db.…Context(ctx, …, query, params...)). Neverquery, _, err := ….?placeholders inside single-quoted SQL literals ingoqu.L(usemake_interval(hours => ?)-style functions instead).//nolint:forbidigoor// #nosec G20xannotation has a one-line justification on the same line that a reviewer can verify.