Optimize and fix thermal_dm for nbar=0 #613
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make test.juliaformatted by running:make format.docs/folder) related to code changes were updated and able to build locally by running:make docs.CHANGELOG.mdshould be updated (regarding to the code changes) and built by running:make changelog.Description
Fix
thermal_dmfornbar=0, which previous returnsNaNresults.The main fix is to avoid evaluating
exp(-β * 0)when filling the diagonal data array. Other changes that improves performances includesj(this mainly matters forBigFloatresults and doesn't hurt for machine size numbers)Here's the measured performance difference compared to master. For dense matrix at larger size the performance is going to be dominated by filling the matrix but for most other cases the performance difference is ~10-30%.