update otl and rand family deps #6038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilload
reviewed
Dec 26, 2025
| 0 | ||
| }; | ||
|
|
||
| global::shutdown_tracer_provider(); |
Member
There was a problem hiding this comment.
We need to call .shutdown on the processor in order to flush and send the in-flight spans. You will have to refactor setup_logging_and_tracing a little bit to do so.
Contributor
Author
There was a problem hiding this comment.
Returned the trace_provider from setup_logging_and_tracing, so it can be shutdown from main.rs.
| let parent_cx = | ||
| global::get_text_map_propagator(|prop| prop.extract(&MetadataMap(request_metadata))); | ||
| Span::current().set_parent(parent_cx); | ||
| let _ = Span::current().set_parent(parent_cx); |
Contributor
Author
There was a problem hiding this comment.
when I run cargo check --all-targets && cargo test in local, it is just warning:
warning: unused `Result` that must be used
--> quickwit-proto/src/lib.rs:199:5
|
199 | Span::current().set_parent(parent_cx);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: this `Result` may be an `Err` variant, which should be handled
= note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default
help: use `let _ = ...` to ignore the resulting value
|
199 | let _ = Span::current().set_parent(parent_cx);
| +++++++
But during CI phase, it shows as an error.
guilload
approved these changes
Dec 29, 2025
Member
guilload
left a comment
guilload
left a comment
There was a problem hiding this comment.
We use the _opt suffix (inconsistently) in this codebase for options.
nico34638
pushed a commit
to nico34638/quickwit
that referenced
this pull request
Jan 5, 2026
* update otl and rand family deps * update lindera family * update 3rd party license * fix tests * update the deps * fix fmt * uodate 3rd license * add resource back * add shutdown to trace_provider * remove comments * fix fmt * address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cargo upgrade --incompatible
-p opentelemetry
-p opentelemetry_sdk
-p opentelemetry-otlp
-p tracing-opentelemetry
&& cargo check --all-targets
cargo upgrade --incompatible
-p rand
-p rand_distr
&& cargo check --all-targets && cargo test
How was this PR tested?
cargo check --all-targets && cargo test
make test-all