fix: prevent once handlers from refiring on epoch termination#3790
Open
nightcityblade wants to merge 1 commit into
Open
fix: prevent once handlers from refiring on epoch termination#3790nightcityblade wants to merge 1 commit into
nightcityblade wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a case where
Events.GET_BATCH_STARTED(once=N)could fire twice ifengine.terminate_epoch(False)was called from that handler.oncefilters now consume matched values and each registered handler gets an independent once filter instance.Changes
onceevent filters stateful so matched values are only emitted once.Testing
python3 -m pytest tests/ignite/engine/test_engine.py::TestEngine::test_terminate_epoch_events_sequence -qpython3 -m pytest tests/ignite/engine/test_custom_events.py::test_once_event_filter tests/ignite/engine/test_custom_events.py::test_custom_events_with_events_list -qpython3 -m pytest tests/ignite/engine/test_engine.py tests/ignite/engine/test_custom_events.py -q -m 'not distributed'Fixes #3625