Overload bool.__new__ for Literal bools

[Gobot1234]

Inspired by microsoft/pyright#5515
Closes #6069

[Gobot1234]

Is there a way to see the projects this affects using mypy-primer using my mypy branch?

[AlexWaygood]

Is there a way to see the projects this affects using mypy-primer using my mypy branch?

The easiest way would be to temporarily push a commit to your mypy PR that makes these edits to mypy/typeshed/stdlib/builtins.pyi

[Gobot1234]

python/mypy#15687 (comment) changes don't appear to be causing any problems

[srittau]

Still waiting for python/mypy#15687.

[Gobot1234]

Is there a way to run this with mypy dev? @srittau

[srittau]

@Gobot1234 You could just temporarily change the mypy version in requirements-tests.txt to point to a git reference in this PR I think we did this before, but couldn't find it in git log.

[github-actions]

Diff from mypy_primer, showing the effect of this PR on open source code:

colour (https://github.com/colour-science/colour)
+ colour/continuous/signal.py:835: error: Argument 1 to "bool" has incompatible type "numpy.bool[builtins.bool]"; expected "_Truthy"  [arg-type]
+ colour/continuous/signal.py:835: note: Following member(s) of "numpy.bool[builtins.bool]" have conflicts:
+ colour/continuous/signal.py:835: note:     Expected:
+ colour/continuous/signal.py:835: note:         def __bool__(self) -> Literal[True]
+ colour/continuous/signal.py:835: note:     Got:
+ colour/continuous/signal.py:835: note:         def __bool__(self) -> bool
+ colour/colorimetry/spectrum.py:415: error: Argument 1 to "bool" has incompatible type "numpy.bool[builtins.bool]"; expected "_Truthy"  [arg-type]
+ colour/colorimetry/spectrum.py:415: note: Following member(s) of "numpy.bool[builtins.bool]" have conflicts:
+ colour/colorimetry/spectrum.py:415: note:     Expected:
+ colour/colorimetry/spectrum.py:415: note:         def __bool__(self) -> Literal[True]
+ colour/colorimetry/spectrum.py:415: note:     Got:
+ colour/colorimetry/spectrum.py:415: note:         def __bool__(self) -> bool

[srittau]

I've removed the "deferred" marker.

We might be able to suppress mypy's warnings, although we should add some tests to ensure that mypy still works correctly despite that.

[Gobot1234]

I've removed the "deferred" marker.

We might be able to suppress mypy's warnings, although we should add some tests to ensure that mypy still works correctly despite that.

Where do you want these?

[AlexWaygood]

I've removed the "deferred" marker.
We might be able to suppress mypy's warnings, although we should add some tests to ensure that mypy still works correctly despite that.

Where do you want these?

You could add a check_bool.py file to this directory: https://github.com/python/typeshed/tree/main/stdlib/%40tests/test_cases/builtins. Docs on how those tests work can be found at https://github.com/python/typeshed/blob/main/tests/REGRESSION.md.