-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
gh-63016: Skip some mmap tests on FreeBSD #143230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
!buildbot freebsd |
|
🤖 New build scheduled with the buildbot fleet by @aisk for commit 5151a11 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F143230%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
|
@picnixz Hi, I'm not sure why FreeBSD doesn't support this usage, but I think we can just skip this test as a fix and assume that FreeBSD simply doesn't support |
|
I didn't look at the buildbot traceback but if the combination is not supported, I'd prefer checking for an exception being raised. |
|
I have a FreeBSD VM and this is the traceback I got: I'm not very familiar with BSD, but I will try to just check the error on FreeBSD. If this is not acceptable, I'll dig into it tomorrow. |
|
I think catching OSError would be sufficient then. What matters is that we don't crash. |
|
!buildbot bsd |
|
🤖 New build scheduled with the buildbot fleet by @aisk for commit ba674d5 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F143230%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
|
I'll wait for the bots to complete and then I'll merge this. |
Uh oh!
There was an error while loading. Please reload this page.