Skip to content

gh-142195: Fixed Popen.communicate indefinite loops #143203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpshead merged 5 commits into from
Dec 28, 2025
Merged

gh-142195: Fixed Popen.communicate indefinite loops #143203

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
67145da
Changed condition to evaluate if timeout is less than or equals to 0
prithviraj-chaudhuri Dec 27, 2025
d2f22e9
📜🤖 Added by blurb_it.
blurb-it[bot] Dec 27, 2025
800debd
Updated blurb to be more descriptive
prithviraj-chaudhuri Dec 28, 2025
6fe2ef3
Fix blurb grammer
prithviraj-chaudhuri Dec 28, 2025
de3df83
update news to mention the module name.
gpshead Dec 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/subprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2140,7 +2140,7 @@ def _communicate(self, input, endtime, orig_timeout):

while selector.get_map():
timeout = self._remaining_time(endtime)
if timeout is not None and timeout < 0:
if timeout is not None and timeout <= 0:
self._check_timeout(endtime, orig_timeout,
stdout, stderr,
skip_check_and_raise=True)
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2025-12-27-00-14-56.gh-issue-142195.UgBEo5.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Changed condition in Lib/subprocess.py _communicate to call _check_timeout when 'timeout <= 0'
Loading