Fix/ec grades #599
Merged
Fix/ec grades #599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Meme EC dates now base off dojo.course['start_date'] - Uses start_date timezone to display dates correctly - All internal datetimes still UTC
Leaderboard and non-unique message thanks totals now de-dupe on the tuple of user_id, source_user_id, and message_id. This eliminates an edge case that could inflate thanks numbers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes meme EC calculation to rely on new
course.ymlvaluestart_datefor beginning of course timeframe. This allows instructors to start their EC calculation whenever they see fit rather than force an arbitrary start time.Thanks calculation for non-unique messages (ex: leaderboard) now deduplicate on (user_id, source_user_id, message_id).