Skip to content

refactor: remove deprecated servers/grpcs in v2#151

Merged
kooksee merged 1 commit into
v2from
remove/grpcs-package
Jul 6, 2026
Merged

refactor: remove deprecated servers/grpcs in v2#151
kooksee merged 1 commit into
v2from
remove/grpcs-package

Conversation

@kooksee

@kooksee kooksee commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • 删除 servers/grpcs 废弃别名包(仓库内无引用,仅为 gatewayserver 薄包装)
  • 同步更新架构文档、legacy-removal.md 清单与 Traefik 注释
  • Breaking:外部项目若仍 import .../servers/grpcs,需改为 servers/gatewayserver

迁移

// 旧
import "github.com/pubgo/lava/v2/servers/grpcs"
grpcs.New(params)

// 新
import "github.com/pubgo/lava/v2/servers/gatewayserver"
gatewayserver.New(params)
// 或需 legacy supervisor 名 grpc-server 时:
gatewayserver.NewWithName(params, "grpc-server")

YAML 键 grpc_server 仍可通过 gatewayserver.LoadConfig 解析(带废弃警告),本次未动。

Test plan

  • go test ./... -short -race

Note

#150 文档统一有重叠;合并本 PR 后可关闭 #150 或将其 rebase 掉重复 diff。

Made with Cursor

The package was a thin alias over gatewayserver with no in-repo callers.
Update architecture docs and legacy-removal checklist accordingly.

Co-authored-by: Cursor <cursoragent@cursor.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request completely removes the deprecated servers/grpcs package (which served as an alias for gatewayserver) and updates all related documentation, configuration files, and Copilot instructions to reference servers/gatewayserver instead. There are no review comments, so no feedback is provided.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@kooksee kooksee merged commit 51e537f into v2 Jul 6, 2026
2 checks passed
@kooksee kooksee deleted the remove/grpcs-package branch July 6, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant