Conversation
For some reason why changed this in below mentioned commit. I don't see any reason why. Let's restore the correct behaviour. Revert: 65aff65 Signed-off-by: Michael Vetter <jubalh@iodoru.org>
Enable the changelog generator to extract issue numbers from 'Fixes:' tags. Signed-off-by: Michael Vetter <jubalh@iodoru.org>
Replace manual deallocation and nullification blocks with `FREE_SET_NULL` and `GFREE_SET_NULL` macros. Signed-off-by: Michael Vetter <jubalh@iodoru.org>
Signed-off-by: Michael Vetter <jubalh@iodoru.org>
Signed-off-by: Michael Vetter <jubalh@iodoru.org>
Signed-off-by: Michael Vetter <jubalh@iodoru.org>
Signed-off-by: Michael Vetter <jubalh@iodoru.org>
Signed-off-by: Michael Vetter <jubalh@iodoru.org>
Describe all options and their values. Hilight the default. Our users asked often for a config file that they can edit. We were reluctant and told them to use the commands inside Profanity because they will also do checks on the input. However I think it's time to give powerusers what they asked for. Signed-off-by: Michael Vetter <jubalh@iodoru.org>
Replace fragile manual string building of timezone with more robust glib solution. Previously it was assumed a specific length and timezone offset suffix (+00:00). This broke if the server used a different timezone offset representation (like 'Z' or +0000). Signed-off-by: Michael Vetter <jubalh@iodoru.org>
Replace all occurrences of legacy GTimeVal timestamp formatting and parsing with the modern GDateTime. Signed-off-by: Michael Vetter <jubalh@iodoru.org>
Replace the not thread safe localtime and strftime manual date formatting with modern GLib GDateTime. Using localtime inside multithreaded environments can lead to race conditions. Signed-off-by: Michael Vetter <jubalh@iodoru.org>
Replace legacy gettimeofday and struct timeval API with standard GLib g_get_real_time. gettimeofday is marked as obsolete in POSIX.1-2008. Using g_get_real_time is more modern, portable, and thread safe. Signed-off-by: Michael Vetter <jubalh@iodoru.org>
Replace unsafe alloca and manual string concatenation with modern GLib g_strconcat. Signed-off-by: Michael Vetter <jubalh@iodoru.org>
Move code from duplicate helper functions _stanza_get_delay_timestamp_xep0203 and _stanza_get_delay_timestamp_xep0091 into parameterized helper _stanza_get_delay_timestamp that accepts the expected XML namespace. Signed-off-by: Michael Vetter <jubalh@iodoru.org>
Merge log_database_get_limits_info and log_database_get_limits_info_muc into a parameterized _db_get_limits_info helper. Extract the duplicate logic from log_database_get_chat_count and log_database_get_muc_count into _db_get_int_result. Signed-off-by: Michael Vetter <jubalh@iodoru.org>
Consolidate SQLite message log parsing loops from chat and MUC history queries. Signed-off-by: Michael Vetter <jubalh@iodoru.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.