fix(mam): do not discard self sent messages received via MAM if sent … - #2196
Merged
Conversation
Member
Author
|
Tested by vamp898 |
…offline Profanity is offline and the user is sending messages from another client, When Profanity comes online and requests MAM history, these self sent messages are received. Before sv_ev_incoming_message classified all MAM messages from our own bare JID as a self reflection, attempted to update their archive ID in the database, and then immediately discarded them by returning early. Since the database update failed because the message was sent while offline, the message was permanently lost and never logged or displayed. Tested-By: vamp898 Signed-off-by: Michael Vetter <jubalh@iodoru.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…offline
Profanity is offline and the user is sending messages from another client,
When Profanity comes online and requests MAM history, these self sent messages are received.
Before sv_ev_incoming_message classified all MAM messages from our own bare JID as a self reflection, attempted to update their archive ID in the database, and then immediately discarded them by returning early. Since the database update failed because the message was sent while offline, the message was permanently lost and never logged or displayed.