fix(omemo): Correctly display our own sent OMEMO messages in MUCs and 1:1 chats - #2195
Merged
Conversation
Member
Author
|
Confirmed by vamp898 in the MUC to fix the issue he reported. |
… 1:1 chats We log our own messages when we send them. Thus we don't have the stable archive ID that the server assigns to it. When we get MAM history (or standard MUC history), we look for the ID, think the message is new and thus display a decryption error because we can't decrypt the message due to double-ratchet. Unify database update and retrieval functions using the prof_msg_type_t enum to stay DRY, and support both MUC and 1:1 chats. Update stable ID for self-reflected messages in our database. So later we can identify them correctly and load them from the DB. Signed-off-by: Michael Vetter <jubalh@iodoru.org>
jubalh
force-pushed
the
fix/mucomemoreflection
branch
from
July 20, 2026 14:34
243d52d to
8e01397
Compare
jubalh
changed the title
Member
Author
Later he found another issue. I updated the commit, lets see. |
Member
Author
|
Confirmed to fix the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We log our own messages when we send them.
Thus we don't have the stable archive ID that the server assigns to it.
When we get MAM history (or standard MUC history), we look for the ID,
think the message is new and thus display a decryption error because
we can't decrypt the message due to double-ratchet.
Unify database update and retrieval functions using the prof_msg_type_t enum
to stay DRY, and support both MUC and 1:1 chats.
Update stable ID for self-reflected messages in our database.
So later we can identify them correctly and load them from the DB.