Gm/dynamic length scan #49
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This builds on #47 which is why there are so many changes. |
Collaborator
Author
|
tests all pass at this point, btw |
georgematheos
force-pushed
the
gm/dynamic_length_scan
branch
from
f2dc6d5 to
ed3d5ca
Compare
Collaborator
Author
|
Marking this as a draft for now, since we can't implement inference in this version of the model yet due to https://github.com/probcomp/genjax/issues/1188. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the latent particle system model, so that the length of the scan combinator can be changed dynamically, via calls to
trace.update.Unfortunately, making this change means that we have to pass around arrays of size
max_num_timestepsthat only containnum_timesteps < max_num_timestepsvalid pieces of data. This means we need to pass aroundgenjax.Maskobjects, and need to be a little bit careful to not to index at invalid time slices in some of the produced data structures.