-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Use correct formula in Beatmap/Circle_size
#13717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Beatmap/Circle_sizeBeatmap/Circle_size
|
Thank you for contributing to the osu! wiki. Please take note of the following:
See the contribution guide for more information. All changes are run through continuous integration checks, which provide automatic detection of common errors. If you need help with decrypting CI check error messages, or with any other issues, ask in the |
|
it should definitely be explained in the article. I don't remember why we left it in a comment like that (probably just didn't get around to writing about it...) |
MChecaH
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did some research to ensure the formula was correct. According to CalculateScaleFromCircleSize which scales objects according to a map's CS. An inconsequential amount, but plays into the formula.
| In [osu!](/wiki/Game_mode/osu!), circle size changes the size of [hit circles](/wiki/Gameplay/Hit_object/Hit_circle) and [sliders](/wiki/Gameplay/Hit_object/Slider), with higher values creating smaller hit objects. [Spinners](/wiki/Gameplay/Hit_object/Spinner) are unaffected by circle size. Circle size is derived through the following formula: | ||
|
|
||
| `r = 54.4 - 4.48 * CS`<!-- multiplied by 1.00041 in the end to account for some bug in old replays --> | ||
| `r = (54.4 - 4.48 * CS) * 1.00041`<!-- multiplied by 1.00041 in the end to account for some bug in old replays --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before merging though, I think it'd be worth explaining where this ratio comes from in plain text rather than a hidden comment. Believe the ratio should be explained as to not let users wondering "what is this for". Especially when we're already commenting all the other variables in the formula.
|
I agree that this should not be a hidden comment. Please add the explanation to the actual wiki pages. |
peppy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As commented

Beatmap/Circle_sizesays circle radius equals54.4 - 4.48 * CSosu pixels. at CS=5, that would equal32, but the correct value (in both stable and lazer) is actually32.01312. both clients also display the (rounded) correct value when hovering over difficulty numbers.the correct formula is:
(54.4 - 4.48 * CS) * 1.00041. (this isn't a rounding error (at least not anymore), it's hardcoded in. a comment in lazer's source code explains why)alternatively,
* 1.00041could be said in a footnote.reason for change:
Self-check