Add options to dump #302
Open
Add options to dump #302
+32
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| assert isinstance(node_svc, PostgresNodeService) | ||
| query_create = 'create table test_options as select generate_series(1, 5) as val' | ||
|
|
||
| with __class__.helper__get_node(node_svc).init().start() as node1: |
Collaborator
There was a problem hiding this comment.
Если я все правильно понимаю, то в случае исключения из init или start у нас не произойдет "захват" создаваемого объекта в with и он не будет "зачищен".
Такая же ситуация чуть ниже.
Мне кажется, что это у нас тут какая-та системная проблема в тестах.
Не критично (есть как плюсы так и минусы), но нужно принять во внимание.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.