Skip to content

Conversation

@rajdip-b
Copy link
Contributor

📋 Summary

Related Issue: Fixes #8593

🎯 What

The PR adds the ability to filter benefits by their type. Below is the relevant screenshot:
image

🤔 Why

🔧 How

🧪 Testing

  • I have tested these changes locally
  • All existing tests pass (uv run task test for backend, pnpm test for frontend)
  • I have added new tests for new functionality
  • I have run linting and type checking (uv run task lint && uv run task lint_types for backend)

Test Instructions

🖼️ Screenshots/Recordings

📝 Additional Notes

✅ Pre-submission Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code where necessary
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have updated the relevant tests
  • All tests pass locally
  • AI/LLM Policy: If I used AI assistance, I have tested and executed the code locally (not just "vibe-coded")

@vercel
Copy link

vercel bot commented Dec 21, 2025

@rajdip-b is attempting to deploy a commit to the polar-sh Team on Vercel.

A member of the Team first needs to authorize it.

@rajdip-b
Copy link
Contributor Author

CC @rishi-raj-jain

@rishi-raj-jain
Copy link
Member

Tick All by default? As we see for "Active" in meters?

@rajdip-b
Copy link
Contributor Author

rajdip-b commented Dec 21, 2025

Tick All by default?

Done
image

@rishi-raj-jain
Copy link
Member

@rajdip-b Can you run the code formatting locally and push?

@rajdip-b
Copy link
Contributor Author

Yes on that rn

@rajdip-b
Copy link
Contributor Author

This looks good ig?

@vercel
Copy link

vercel bot commented Dec 21, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Review Updated (UTC)
polar-sandbox Ignored Ignored Preview Dec 21, 2025 7:01am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add benefit type filtering to benefits management screen

2 participants