Single-package repo layout, 10.0.0 changelog consolidation, and Windows IPv6 (#71)#89
Merged
Merged
Conversation
Collapse the dart_ping/ package directory into the repository root now that it is the only package (dart_ping_ios is retired). lib/, test/, hook/, native/, example/, pubspec.yaml, CHANGELOG.md, LICENSE and the analysis/test config move up to the root. CI working-directories, SPEC.md path references, the merged single README, and the consolidated .gitignore/.vscode are updated to match. No package API or behavior change.
Fold the never-published 9.1.0 / 9.1.1 / 9.2.0 entries into one 10.0.0 entry (Breaking & migration / Added / Changed / Fixed) directly above the last released 9.0.1, and document the previously-missing sealed PingEvent stream breaking change with its migration. Modernize the stale pubspec description (it predated iOS support) and add topics + issue_tracker for pub.dev.
Windows ping supports IPv6 (confirmed on Server 2022, #71), so PingWindows.params now forces -6 for IpVersion.ipv6 instead of throwing UnimplementedError. The Windows reply parser is broadened because IPv6 replies omit bytes= and TTL= (e.g. 'Reply from ::1: time<1ms'), so an IPv6 probe carries no hop TTL. The macOS subprocess path remains IPv4-only and still raises an explicit error for an IPv6 selection. Docs (SPEC, CHANGELOG, README) updated so the no-IPv6 example points at the macOS subprocess path rather than Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four focused commits, each building independently (
dart analyze --fatal-infosclean;dart test -x livegreen at every step).Commits
chore(repo): pull dart_ping source to repo root (single package)— collapses thedart_ping/package directory into the repo root now that it is the only package (dart_ping_iosretired).lib/,test/,hook/,native/,example/,pubspec.yaml,CHANGELOG.md,LICENSE, and the analysis/test config move up. CI working-dirs, the 47dart_ping/path references inSPEC.md, the merged single README, and.gitignore/.vscodeare updated to match. No package API or behavior change.docs(changelog): consolidate post-9.0.1 changes into a single 10.0.0— folds the never-published 9.1.0 / 9.1.1 / 9.2.0 entries into one10.0.0(Breaking & migration / Added / Changed / Fixed) above the last released 9.0.1, and documents the previously-missing sealedPingEventstream breaking change with its migration. Also modernizes the stale pubspecdescription(it predated iOS support) and addstopics:+issue_tracker:.feat(#71): support IPv6 on Windows via -6— Windowspingsupports IPv6 (confirmed on Server 2022, [Windows] IPv6 is implemented (at least on some windows versions) #71), soPingWindows.paramsnow forces-6forIpVersion.ipv6instead of throwingUnimplementedError. The Windows reply parser is broadened because IPv6 replies omitbytes=andTTL=(Reply from ::1: time<1ms), so an IPv6 probe carries no hop TTL. The macOS subprocess path remains IPv4-only and still raises an explicit error. SPEC/CHANGELOG/README reconciled so the no-IPv6 example points at the macOS subprocess path.docs(changelog): drop the 10.0.0 intro paragraphNotes / not validated here
ios-swiftCI job (xcodebuild test) and the live Windows-IPv6 ping path are real-host acceptance checks — they don't run on the Linux dev host. The deterministic seams (command construction + reply parsing against [Windows] IPv6 is implemented (at least on some windows versions) #71's real sample output) are covered bydart test.