[test] Broken rules when mixing CSS and xpath rules #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test showcases an error we noticed at www.freitag.de: If you have the very same rules, but one written with CSS selectors and the other with xpath selectors, but only one should be applied at a time (there's a conditional guard for each of them) the conditional is ignored and both rules are applied. This does not happen if both rules are done in either CSS or xpath...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests showcase an error we noticed at www.freitag.de:
If you have the very same rules,
but one written with CSS selectors and the other with xpath selectors,
but only one should be applied at a time (there's a conditional guard for each of them)
the conditional is ignored and both rules are applied.
This does not happen if both rules are done in either CSS or xpath as can be seen on the
css-css-same-elementandxpath-xpath-same-elementtests.The puzzling thing is that depending on the inner rules a conditional is applied or not.