feat(provider): scaffold Sazabi cloud provider#4316
Conversation
Add contracts, driver, availability probe, an empty (not-yet-streaming) adapter, and heuristic text generation for Sazabi as a cloud provider (Path A: talks to the Sazabi public API over HTTP/SSE, not a local ACP CLI harness). Scope (PR T1 — scaffold only): - contracts: `sazabi` driver kind, `SazabiSettings` (enabled, apiBaseUrl, projectId, optional binaryPath), legacy `providers.sazabi` hydration, model defaults + display name. The API token is read from the `SAZABI_TOKEN` env var and is deliberately absent from settings so no secret is persisted to disk. - driver + probe: `SazabiDriver` registered in `builtInDrivers`; `SazabiProvider` reports availability from auth presence (SAZABI_TOKEN, or an optional `sazabi whoami`) with a clear unavailable reason. - adapter: implements `ProviderAdapterShape` with a wired-up (empty) `streamEvents` PubSub; session/turn ops return clear "not implemented" errors and interrupt/stop are safe no-ops. - web: minimal catalog wiring so the provider shows in settings. - tests: settings decode, probe unavailable-without-token, adapter stubs. Depends on the upcoming Sazabi public API (messages send / SSE stream / cancel). PR T2 replaces the stub adapter with real streaming + interrupt->cancel + tool item lifecycle. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
vouch:unvouched
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d2e0f75. Configure here.
| placeholder: DEFAULT_SAZABI_API_BASE_URL, | ||
| clearWhenEmpty: "omit", | ||
| }, | ||
| }), |
There was a problem hiding this comment.
API base URL default never applied
Low Severity
DEFAULT_SAZABI_API_BASE_URL is documented as the fallback when apiBaseUrl is blank, and the form describes the field as an override with that URL as the placeholder, but decoding defaults apiBaseUrl to "" and nothing applies the constant. Blank settings therefore do not resolve to the advertised base URL once request code lands.
Reviewed by Cursor Bugbot for commit d2e0f75. Configure here.
ApprovabilityVerdict: Needs human review This PR introduces a new cloud provider (Sazabi) with cross-cutting changes across server, web, and contracts packages. While explicitly a scaffold with disabled-by-default behavior, it adds new user-facing capability in the provider catalog and settings UI, warranting human review for the integration approach. You can customize Macroscope's approvability policy. Learn more. |
|
Closing — this work was meant to stay local; opened by mistake via a personal fork. |
1 participant
No description provided.