Skip to content

[codex] Group project scopes in mobile thread lists#4314

Merged
juliusmarminge merged 4 commits into
mainfrom
codex/mobile-grouped-project-scopes
Jul 23, 2026
Merged

[codex] Group project scopes in mobile thread lists#4314
juliusmarminge merged 4 commits into
mainfrom
codex/mobile-grouped-project-scopes

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Jul 22, 2026

Copy link
Copy Markdown
Member

Why

Mobile thread lists treat copies of the same repository in different environments as unrelated projects. Selecting one project can therefore hide threads from the other copy.

Root cause

Mobile list filtering accepts one physical project reference, while project presentation is expected to operate on logical repository groups.

Fix

  • derive logical project scopes for the mobile home screen
  • filter threads and pending tasks by every member project reference
  • allow Thread List v2 to accept multiple project references
  • preserve grouped sorting and stale duplicate references

Settings placement and startup preference behavior are intentionally excluded from this PR.

Verification

  • targeted formatting and lint
  • vp run --filter @t3tools/mobile typecheck
  • focused mobile grouping and Thread List v2 tests — 22 tests passed

Note

Group project scopes by repository identity in mobile thread lists

  • Introduces buildHomeProjectScopes and sortHomeProjectScopes in homeThreadList.ts to consolidate duplicate projects across environments into logical groups, sorted by recent thread/task activity.
  • Updates buildThreadListV2Items in threadListV2.ts to accept an array of projectRefs instead of a single ref, enabling multi-environment project filtering.
  • Updates the home screen and thread navigation sidebar to select and filter by logical project scopes rather than individual projects, with empty states reflecting the selected scope title.
  • Behavioral Change: thread and pending-task filtering now matches any projectRef within the selected logical scope, so selecting a project may include threads from multiple environments.

Macroscope summarized c71bc86.


Note

Medium Risk
Changes core list filtering and grouping logic for home/sidebar/v2 paths; behavior is well covered by new tests but wrong scope resolution could hide or mis-attribute threads.

Overview
Mobile home and sidebar thread lists now treat logical project groups (same repo across environments, including stale duplicate project IDs) as one filter scope instead of a single physical project ref.

buildHomeProjectScopes and sortHomeProjectScopes in homeThreadList.ts derive grouped scopes with merged projectRefs, reuse them in buildHomeThreadGroups, and improve new-thread target resolution when threads still point at stale project IDs.

HomeScreen and ThreadNavigationSidebar build project filter options from scopes, match selection by scope key or any member ref, and scope v1/v2 threads and pending tasks across all refs. Empty states use the group title.

Thread List v2 takes projectRefs (array) instead of one projectRef, so filtering includes every environment copy in the group.

Reviewed by Cursor Bugbot for commit c71bc86. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 0d2b0e7e-4d19-4920-a5c3-3910df1de4dc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/mobile-grouped-project-scopes

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Jul 22, 2026
Comment thread apps/mobile/src/features/home/HomeScreen.tsx
Comment thread apps/mobile/src/features/home/homeThreadList.ts
@juliusmarminge
juliusmarminge marked this pull request as ready for review July 22, 2026 22:35
Comment thread apps/mobile/src/features/home/HomeScreen.tsx Outdated
Comment thread apps/mobile/src/features/home/HomeScreen.tsx
@macroscopeapp

macroscopeapp Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR introduces new project grouping functionality that merges projects across environments by repository identity, changing how thread lists are filtered and displayed. The scope of new logic and runtime behavior changes warrants human review.

You can customize Macroscope's approvability policy. Learn more.

juliusmarminge and others added 2 commits July 23, 2026 14:21
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
@juliusmarminge
juliusmarminge force-pushed the codex/mobile-grouped-project-scopes branch from 6a06232 to d089f8f Compare July 23, 2026 12:23
Comment thread apps/mobile/src/features/home/homeThreadList.ts Outdated
Comment thread apps/mobile/src/features/home/homeThreadList.ts
Comment thread apps/mobile/src/features/threads/ThreadNavigationSidebar.tsx Outdated
Co-authored-by: codex <codex@users.noreply.github.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is ON, but a cloud agent failed to start.

Reviewed by Cursor Bugbot for commit 7e09d54. Configure here.

Comment thread apps/mobile/src/features/threads/ThreadNavigationSidebar.tsx
Co-authored-by: codex <codex@users.noreply.github.com>
@juliusmarminge
juliusmarminge merged commit 0542abc into main Jul 23, 2026
16 checks passed
@juliusmarminge
juliusmarminge deleted the codex/mobile-grouped-project-scopes branch July 23, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant