[codex] Move project grouping to General settings#4313
Conversation
Co-authored-by: codex <codex@users.noreply.github.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
ApprovabilityVerdict: Approved UI reorganization moving project grouping controls from sidebar menu to General settings. The underlying functionality is unchanged; only the control location and a minor localStorage enhancement for remembering the last enabled mode are added. Self-contained with unit tests. You can customize Macroscope's approvability policy. Learn more. |
Co-authored-by: codex <codex@users.noreply.github.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
Bugbot Autofix is ON, but a cloud agent failed to start.
Reviewed by Cursor Bugbot for commit a63dcc7. Configure here.
Co-authored-by: codex <codex@users.noreply.github.com>
Dismissing prior approval to re-evaluate 1236131

Why
Project grouping is currently exposed as a sidebar-specific organization control even though the preference affects project identity across the application. Keeping it beside sorting controls makes its scope unclear.
Root cause
The grouping preference was surfaced from the legacy sidebar menu instead of the global settings surface.
Fix
This PR contains only the web setting relocation and does not change Sidebar V2 grouping behavior.
Verification
vp run --filter @t3tools/web typecheckvp test run apps/web/src/components/settings/SettingsPanels.logic.test.ts— 7 tests passedNote
Move project grouping control from sidebar sort menu to General settings
ProjectSortMenuin Sidebar.tsx; the sidebar sort menu now only controls sort order and thread preview count.GeneralSettingsPanelin SettingsPanels.tsx that maps tosidebarProjectGroupingMode.separategrouping mode to localStorage via new helpers in SettingsPanels.logic.ts so toggling back restores the previous mode.sidebarProjectGroupingMode.Macroscope summarized 1236131.
Note
Low Risk
UI relocation only; same setting key and grouping behavior, with tests for toggle mapping and no auth or data-path changes.
Overview
Project grouping is edited in Settings → General instead of the legacy sidebar project sort menu, so it reads as an app-wide preference rather than a sidebar-only sort option.
The new Project Grouping switch still drives
sidebarProjectGroupingMode: off sets separate; on restores the last enabled mode (repository or repository_path). That last mode is kept in a ref and inlocalStoragewhen you turn grouping off, so toggling back does not collapserepository_pathinto repository. Restore-defaults and the changed-settings list now include project grouping.The Group projects radio block and related props/handlers are removed from
ProjectSortMenuinSidebar.tsx; sort/preview controls in that menu are unchanged.Reviewed by Cursor Bugbot for commit 1236131. Bugbot is set up for automated code reviews on this repo. Configure here.