Skip to content

[codex] Move project grouping to General settings#4313

Open
juliusmarminge wants to merge 3 commits into
mainfrom
codex/project-grouping-setting
Open

[codex] Move project grouping to General settings#4313
juliusmarminge wants to merge 3 commits into
mainfrom
codex/project-grouping-setting

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Jul 22, 2026

Copy link
Copy Markdown
Member

Why

Project grouping is currently exposed as a sidebar-specific organization control even though the preference affects project identity across the application. Keeping it beside sorting controls makes its scope unclear.

Root cause

The grouping preference was surfaced from the legacy sidebar menu instead of the global settings surface.

Fix

  • add Project Grouping to Settings → General
  • preserve the previous repository-path grouping choice when toggling
  • remove the duplicate control from the legacy sidebar menu

This PR contains only the web setting relocation and does not change Sidebar V2 grouping behavior.

Verification

  • targeted formatting and lint
  • vp run --filter @t3tools/web typecheck
  • vp test run apps/web/src/components/settings/SettingsPanels.logic.test.ts — 7 tests passed

Note

Move project grouping control from sidebar sort menu to General settings

  • Removes the 'Group projects' radio group from ProjectSortMenu in Sidebar.tsx; the sidebar sort menu now only controls sort order and thread preview count.
  • Adds a 'Project Grouping' toggle to GeneralSettingsPanel in SettingsPanels.tsx that maps to sidebarProjectGroupingMode.
  • Persists the last non-separate grouping mode to localStorage via new helpers in SettingsPanels.logic.ts so toggling back restores the previous mode.
  • Restoring defaults in General settings now also resets sidebarProjectGroupingMode.

Macroscope summarized 1236131.


Note

Low Risk
UI relocation only; same setting key and grouping behavior, with tests for toggle mapping and no auth or data-path changes.

Overview
Project grouping is edited in Settings → General instead of the legacy sidebar project sort menu, so it reads as an app-wide preference rather than a sidebar-only sort option.

The new Project Grouping switch still drives sidebarProjectGroupingMode: off sets separate; on restores the last enabled mode (repository or repository_path). That last mode is kept in a ref and in localStorage when you turn grouping off, so toggling back does not collapse repository_path into repository. Restore-defaults and the changed-settings list now include project grouping.

The Group projects radio block and related props/handlers are removed from ProjectSortMenu in Sidebar.tsx; sort/preview controls in that menu are unchanged.

Reviewed by Cursor Bugbot for commit 1236131. Bugbot is set up for automated code reviews on this repo. Configure here.

Co-authored-by: codex <codex@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 98ca50d7-4e02-4c34-a89f-41a70cce183e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/project-grouping-setting

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Jul 22, 2026
@juliusmarminge
juliusmarminge marked this pull request as ready for review July 22, 2026 22:35
Comment thread apps/web/src/components/settings/SettingsPanels.tsx
@macroscopeapp

macroscopeapp Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

UI reorganization moving project grouping controls from sidebar menu to General settings. The underlying functionality is unchanged; only the control location and a minor localStorage enhancement for remembering the last enabled mode are added. Self-contained with unit tests.

You can customize Macroscope's approvability policy. Learn more.

Co-authored-by: codex <codex@users.noreply.github.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is ON, but a cloud agent failed to start.

Reviewed by Cursor Bugbot for commit a63dcc7. Configure here.

Comment thread apps/web/src/components/settings/SettingsPanels.tsx Outdated
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Jul 22, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
@macroscopeapp
macroscopeapp Bot dismissed their stale review July 22, 2026 23:23

Dismissing prior approval to re-evaluate 1236131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant