OWNERS: sync master to release-8.5#69543
Conversation
skip-checks: true Signed-off-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
📝 WalkthroughWalkthroughThe root ChangesOWNERS and OWNERS_ALIASES restructuring
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pkg/executor/OWNERS`:
- Around line 2-7: The OWNERS config for pkg/executor currently leaves most
files unowned because no_parent_owners is enabled and only the analyze.*\.go$
filter has approvers. Update the OWNERS file to add a default approver block
that covers pkg/executor/ broadly, or remove no_parent_owners if parent
ownership should apply, while keeping the existing analyze.*\.go$ routing
intact.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 587778ef-356f-4966-a839-87bef9159393
📒 Files selected for processing (21)
OWNERSOWNERS_ALIASESpkg/dumpformat/OWNERSpkg/dxf/OWNERSpkg/executor/OWNERSpkg/executor/aggfuncs/OWNERSpkg/executor/aggregate/OWNERSpkg/executor/join/OWNERSpkg/executor/mppcoordmanager/OWNERSpkg/executor/sortexec/OWNERSpkg/executor/test/analyzetest/OWNERSpkg/executor/unionexec/OWNERSpkg/ingestor/OWNERSpkg/lightning/config/OWNERSpkg/meta/metadef/OWNERSpkg/metrics/OWNERSpkg/objstore/OWNERSpkg/session/OWNERSpkg/sessionctx/vardef/OWNERSpkg/statistics/OWNERSpkg/util/naming/OWNERS
| options: | ||
| no_parent_owners: true | ||
| filters: | ||
| "analyze.*\\.go$": | ||
| approvers: | ||
| - sig-approvers-stats |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Top-level files in pkg/executor not matched by analyze.*\\.go$:"
fd -t f --max-depth 1 . pkg/executor | python - <<'PY'
import pathlib
import re
import sys
pat = re.compile(r'^analyze.*\.go$')
for raw in sys.stdin:
path = raw.strip()
if not path:
continue
name = pathlib.Path(path).name
if name == "OWNERS":
continue
if not pat.match(name):
print(path)
PYRepository: pingcap/tidb
Length of output: 213
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf 'Files under pkg/executor:\n'
git ls-files pkg/executor
printf '\nTop-level files under pkg/executor:\n'
python3 - <<'PY'
import pathlib
from collections import defaultdict
files = [pathlib.Path(p) for p in open(0).read().splitlines()]
top = [p for p in files if len(p.parts) == 2 and p.name != "OWNERS"]
for p in top:
print(p)
PY <<'EOF'
$(git ls-files pkg/executor)
EOFRepository: pingcap/tidb
Length of output: 17970
Add a fallback approver for pkg/executor/
no_parent_owners: true leaves the many top-level files in pkg/executor/ without any approver routing; the only local filter covers analyze*.go. Add a default approver block here, or drop no_parent_owners if that’s intentional.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@pkg/executor/OWNERS` around lines 2 - 7, The OWNERS config for pkg/executor
currently leaves most files unowned because no_parent_owners is enabled and only
the analyze.*\.go$ filter has approvers. Update the OWNERS file to add a default
approver block that covers pkg/executor/ broadly, or remove no_parent_owners if
parent ownership should apply, while keeping the existing analyze.*\.go$ routing
intact.
|
Looks good to me. The change is minimal and targeted, which I appreciate. LGTM once CI is green. |
What problem does this PR solve?
Sync
OWNERS*files frommastertorelease-8.5.What changed and how does it work?
This PR was auto-generated by Prow and only updates
OWNERSandOWNERS_ALIASESfiles./release-note-none
skip-issue-check
lgtm
approved
cherry-pick-approved
Summary by CodeRabbit
New Features
Bug Fixes
Chores