Skip to content

OWNERS: sync master to release-8.5#69543

Open
ti-chi-bot wants to merge 1 commit into
release-8.5from
bot/sync-owners-to-release-8.5
Open

OWNERS: sync master to release-8.5#69543
ti-chi-bot wants to merge 1 commit into
release-8.5from
bot/sync-owners-to-release-8.5

Conversation

@ti-chi-bot

@ti-chi-bot ti-chi-bot commented Jun 30, 2026

Copy link
Copy Markdown
Member

What problem does this PR solve?

Sync OWNERS* files from master to release-8.5.

What changed and how does it work?

This PR was auto-generated by Prow and only updates OWNERS and OWNERS_ALIASES files.

/release-note-none
skip-issue-check
lgtm
approved
cherry-pick-approved

Summary by CodeRabbit

  • New Features

    • Expanded ownership rules across multiple areas of the project, including more specific approval paths for executor, metrics, statistics, DDL, metadata, and session-related changes.
  • Bug Fixes

    • Updated review routing so different files and directories now go to the appropriate reviewer groups.
    • Refined ownership handling to avoid inheriting parent rules where tighter control is needed.
  • Chores

    • Updated ownership aliases and group memberships to reflect the latest reviewer and approver assignments.

skip-checks: true
Signed-off-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added approved cherry-pick-approved Cherry pick PR approved by release team. lgtm skip-issue-check Indicates that a PR no need to check linked issue. labels Jun 30, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jun 30, 2026

Copy link
Copy Markdown

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jun 30, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jun 30, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ailinkid, gmhdbjd, yudongusa for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed approved labels Jun 30, 2026
@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The root OWNERS file is restructured from explicit lists to a filters-based configuration. OWNERS_ALIASES gains new aliases (sig-approvers-stats, sig-critical-approvers-dep, sig-approvers-metrics) with broad membership updates, and removes sig-approvers-disttask. Numerous per-package OWNERS files are added or updated with no_parent_owners: true and targeted approver groups.

Changes

OWNERS and OWNERS_ALIASES restructuring

Layer / File(s) Summary
OWNERS_ALIASES alias additions and membership updates
OWNERS_ALIASES
Adds sig-approvers-stats, sig-critical-approvers-dep, and sig-approvers-metrics aliases; revises membership of sig-critical-approvers-*, sig-approvers-*, sig-community-reviewers, and sig-community-approvers; removes sig-approvers-disttask.
Root OWNERS filter-based routing
OWNERS
Replaces top-level approvers/reviewers with a filters block routing go.mod$ paths to sig-critical-approvers-dep and all other paths to sig-community-approvers/sig-community-reviewers.
Per-package OWNERS files added and updated
pkg/dumpformat/OWNERS, pkg/dxf/OWNERS, pkg/executor/OWNERS, pkg/executor/*/OWNERS, pkg/ingestor/OWNERS, pkg/lightning/config/OWNERS, pkg/meta/metadef/OWNERS, pkg/metrics/OWNERS, pkg/session/OWNERS, pkg/sessionctx/vardef/OWNERS, pkg/statistics/OWNERS, pkg/util/naming/OWNERS
Adds new OWNERS files with no_parent_owners: true and specific approver groups for each package; updates existing files with revised approver groups and filter rules (e.g., sig-approvers-dumpling, sig-approvers-executor, sig-approvers-stats, sig-approvers-ddl, sig-critical-approvers-tidb-server).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • pingcap/tidb#67717: Updates the same OWNERS/OWNERS_ALIASES files with overlapping sig-community-* and sig-approvers-* membership changes.
  • pingcap/tidb#68891: Directly overlaps with the sig-approvers-disttasksig-approvers-dxf/sig-approvers-dumpling routing changes in pkg/dumpformat/OWNERS and pkg/dxf/OWNERS.
  • pingcap/tidb#68706: Rewrites the same OWNERS/OWNERS_ALIASES approver/reviewer and alias membership rules at the same level.

Suggested labels

approved

Suggested reviewers

  • windtalker
  • wshwsh12
  • GMHDBJD

Poem

🐇 Hoppity hop through the OWNERS tree,
Filters replace what was listed by hand,
New aliases bloom for stats, dep, and metrics glee,
Each package now knows just who's in command.
No parent needed when local rules stand!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description covers the main change, but it omits required template sections like Issue Number, checklist, side effects, documentation, and release note. Add the missing template sections, especially an Issue Number line, checklist items, side effects/documentation, and a proper release note.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states the OWNERS sync from master to release-8.5 and matches the main change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bot/sync-owners-to-release-8.5

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@pkg/executor/OWNERS`:
- Around line 2-7: The OWNERS config for pkg/executor currently leaves most
files unowned because no_parent_owners is enabled and only the analyze.*\.go$
filter has approvers. Update the OWNERS file to add a default approver block
that covers pkg/executor/ broadly, or remove no_parent_owners if parent
ownership should apply, while keeping the existing analyze.*\.go$ routing
intact.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 587778ef-356f-4966-a839-87bef9159393

📥 Commits

Reviewing files that changed from the base of the PR and between df2282c and fe0c0c6.

📒 Files selected for processing (21)
  • OWNERS
  • OWNERS_ALIASES
  • pkg/dumpformat/OWNERS
  • pkg/dxf/OWNERS
  • pkg/executor/OWNERS
  • pkg/executor/aggfuncs/OWNERS
  • pkg/executor/aggregate/OWNERS
  • pkg/executor/join/OWNERS
  • pkg/executor/mppcoordmanager/OWNERS
  • pkg/executor/sortexec/OWNERS
  • pkg/executor/test/analyzetest/OWNERS
  • pkg/executor/unionexec/OWNERS
  • pkg/ingestor/OWNERS
  • pkg/lightning/config/OWNERS
  • pkg/meta/metadef/OWNERS
  • pkg/metrics/OWNERS
  • pkg/objstore/OWNERS
  • pkg/session/OWNERS
  • pkg/sessionctx/vardef/OWNERS
  • pkg/statistics/OWNERS
  • pkg/util/naming/OWNERS

Comment thread pkg/executor/OWNERS
Comment on lines +2 to +7
options:
no_parent_owners: true
filters:
"analyze.*\\.go$":
approvers:
- sig-approvers-stats

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "Top-level files in pkg/executor not matched by analyze.*\\.go$:"
fd -t f --max-depth 1 . pkg/executor | python - <<'PY'
import pathlib
import re
import sys

pat = re.compile(r'^analyze.*\.go$')
for raw in sys.stdin:
    path = raw.strip()
    if not path:
        continue
    name = pathlib.Path(path).name
    if name == "OWNERS":
        continue
    if not pat.match(name):
        print(path)
PY

Repository: pingcap/tidb

Length of output: 213


🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf 'Files under pkg/executor:\n'
git ls-files pkg/executor

printf '\nTop-level files under pkg/executor:\n'
python3 - <<'PY'
import pathlib
from collections import defaultdict

files = [pathlib.Path(p) for p in open(0).read().splitlines()]
top = [p for p in files if len(p.parts) == 2 and p.name != "OWNERS"]
for p in top:
    print(p)
PY <<'EOF'
$(git ls-files pkg/executor)
EOF

Repository: pingcap/tidb

Length of output: 17970


Add a fallback approver for pkg/executor/
no_parent_owners: true leaves the many top-level files in pkg/executor/ without any approver routing; the only local filter covers analyze*.go. Add a default approver block here, or drop no_parent_owners if that’s intentional.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@pkg/executor/OWNERS` around lines 2 - 7, The OWNERS config for pkg/executor
currently leaves most files unowned because no_parent_owners is enabled and only
the analyze.*\.go$ filter has approvers. Update the OWNERS file to add a default
approver block that covers pkg/executor/ broadly, or remove no_parent_owners if
parent ownership should apply, while keeping the existing analyze.*\.go$ routing
intact.

@goransh-buh

Copy link
Copy Markdown

Looks good to me. The change is minimal and targeted, which I appreciate. LGTM once CI is green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. lgtm sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants