[diffs] CodeView: Custom header / footer support#926
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
amadeus
force-pushed
the
amadeus/codeview-header-footer
branch
from
4e83db5 to
5c05390
Compare
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5c05390ae4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
amadeus
force-pushed
the
amadeus/codeview-header-footer
branch
from
c6b154c to
f10c561
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 49c0af4cb5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
* DOM reconcilation stuff * Various math-ing stuff * Lots of verbose comments by claude
Cleaned up some slop from earlier on the initial measure, but then also added the ResizeObserver stuff
Took a bit of back and forth from the robot to get on the right solution that worked within the same confines of before.
* Prevent scroll fixing if scrolled to the top and a header component is added lazily * Scroll to should take the header into account
Dunno why, i just prefer that...
amadeus
force-pushed
the
amadeus/codeview-header-footer
branch
from
bc2dab6 to
e9da2b9
Compare
1 participant
Add support for custom rendered header/footer content sections in
CodeViewI figured out an API that shouldn't really depend on knowing how tall things are, the elements are intentionally not virtualized and should automatically be tracked by ResizeObservers.
I went for an implementation that would the lightest weight to start with to get a sense of how useful the API might be for people.
An example of it working in DiffsHub (although I don't think we'll ship this):
Header Example:
Footer Example:
Fixes #894