Respect sys_get_temp_dir() from the parent process #4699
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Semi related, some of these usages probably should be changed to respect the application config's 
|
Member
|
I'd merge this but please fix CS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how this should be tested on the CI, but I tested this locally and verified that it fixes phpstan/phpstan#13929.
If I understand the code in
CommandHelpercorrectly,parameters.tmpDirwill override this if set. This is a bit annoying, but since there's no way (that I know of) to tell if an ini setting was set on CLI override or by php.ini, I suppose this is the most predictable behaviour.It doesn't look too difficult to add a command line option to override the tmpDir from what I can see, although I'm not too clear how that would interact with the dependency injection, so I'm reluctant to mess with it for now.