Reduce gh22570 test nesting depth to fix macOS ZTS timeout#22626
Closed
iliaal wants to merge 1 commit into
Closed
Conversation
The 100000-node tree could exceed the run-tests timeout on the macOS ZTS runner. The 512K stack limit overflows well below 10000 nested nodes, so reduce the depth to keep the test fast while still tripping the serializer stack guard.
Member
|
This issue was already fixed here: #22612 |
Contributor
Author
|
Ah yes, missed it. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #22576. The gh22570 test builds a 100000-node tree, which timed out (120s) on the macOS ZTS nightly runner. At
zend.max_allowed_stack_size=512Kthe serializer overflows well below 10000 nested nodes, so reducing the depth keeps the test fast while still tripping the stack guard it verifies.