ext/ldap: fix ldap_explode_dn result ordering and simplify count handling#22519
Open
arshidkv12 wants to merge 3 commits into
Open
ext/ldap: fix ldap_explode_dn result ordering and simplify count handling#22519arshidkv12 wants to merge 3 commits into
arshidkv12 wants to merge 3 commits into
Conversation
Girgias
requested changes
Jul 2, 2026
Girgias
left a comment
Girgias
left a comment
Member
There was a problem hiding this comment.
Just move the add_assoc_long() call prior to the for loop
Member
|
Also needs to target a lower branch. |
Girgias
reviewed
Jul 2, 2026
| array_init(return_value); | ||
| int i; | ||
|
|
||
| for (i = 0; ldap_value[i] != NULL; i++); |
Contributor
Author
There was a problem hiding this comment.
Sorry, I'm a bit confused. Could you please clarify what you mean?
Is the following correct?
add_assoc_long(return_value, "count", 0);
for (i = 0; ldap_value[i] != NULL; i++) {
add_index_string(return_value, i, ldap_value[i]);
}
add_assoc_long(return_value, "count", i);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#22511