Document deprecation of non-callable strings in xml_set_* handler functions #5096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
reviewed
Jan 13, 2026
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
This isn't really a proper fix for the rendering bug.
Ideally, PhD should be able to handle a <replaceable> tag that is not the last child. I don't mind using this PR as a way to resolve the crappy rendering for the time being but this definitely does not close the PhD issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing non-callable strings to xml_set_* handler functions is now deprecated.
This change documents the deprecation to align the manual with current engine behavior
and helps avoid confusion around valid handler values.
php/phd#171