Conversation
audrey-yang
requested changes
Mar 19, 2022
Member
audrey-yang
left a comment
There was a problem hiding this comment.
Header bar position looks good! Could you change two things?
- Keep the height of the landing image to be automatic (it's ok if it's a little cut off)
- Make sure there is no gap between the landing background and bar on smaller screens (same issue as #4)
Author
I made the following changes. However, when you resize the window, the position of the header doesnt get updated right away, you need to reload the page for the position to update. I tried using useEffect to update it dynamically but the way the image load in and how the ref is set makes it complicated to get the height of the image. Lmk if theres a better way of doing this. |
Member
|
@andyjiang3 Hmm, I think bringing back Joe's change from #4 that used |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #12