fix(transformer): add this param to jsxDEV in automatic dev mode for class fields
#16674
+50
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When JSX appears in class fields with
setPublicClassFields: true, the class properties transform moves the JSX into a constructor. Thethisparameter was being omitted fromjsxDEVcalls in these constructors when a superclass exists.Changes
can_add_self_attributecheck for automatic dev mode - In automatic mode,thisis passed as a function argument tojsxDEV(), not accessed as a property. Safe even beforesuper().__self: thisto props object, which requires the check to avoid "this before super" errors.Example
Input:
Before (incorrect):
After (correct):
Matches esbuild, SWC, TypeScript, and Babel behavior.
Original prompt
thisparam for dev automatic transform whenassumptions.setPublicClassFields: true#16654💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.