feat(linter/plugins): add ignoreNonFatalErrors option to RuleTester
#16672
+306
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-linter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Member
Author
Merge activity
|
graphite-app
bot
changed the base branch from
12-09-test_linter_plugins_add_1_more_test_case_for_sourcetype_in_ruletester_
to
graphite-base/16672
…r` (#16672) Add an option to `RuleTester` to ignore non-fatal parsing errors. ```js const tester = new RuleTester({ languageOptions: { sourceType: "module", parserOptions: { ignoreNonFatalErrors: true, }, }, }); tester.run("my-rule", rule, { valid: [ // This is invalid code, but it gets a pass "function f(x, x) {}", ], invalid: [], }); ``` This will be useful in conformance tests, because ESLint's tests contain invalid syntax in many of their test cases!
graphite-app
bot
force-pushed
the
12-09-feat_linter_plugins_add_ignorenonfatalerrors_option_to_ruletester_
branch
from
227caf0 to
e39f487
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an ignoreNonFatalErrors option to RuleTester to allow parsing to continue despite non-fatal parsing errors. This feature is designed to support ESLint conformance tests, which often contain intentionally invalid syntax in test cases. When enabled, the parser will ignore parsing and semantic errors (but not panics), allowing the linter to still run on the partially-valid AST.
Key changes:
- Added
ignoreNonFatalErrorsboolean option to parser options, configurable at global, RuleTester instance, or individual test case level - Implemented proper option merging with right-to-left precedence (local overrides base)
- Optimized to skip semantic analysis when errors are being ignored
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/oxlint/src/js_plugins/parse.rs | Adds Rust-side handling of ignore_non_fatal_errors option, modifying parsing failure detection logic and skipping semantic analysis when errors are ignored |
| apps/oxlint/src-js/package/rule_tester.ts | Adds TypeScript interface for ignoreNonFatalErrors, implements option extraction in getParseOptions, and adds mergeParserOptions helper for proper config merging |
| apps/oxlint/src-js/bindings.d.ts | Auto-generated NAPI bindings with new ignoreNonFatalErrors field in ParserOptions interface |
| apps/oxlint/test/rule_tester.test.ts | Comprehensive test suite covering default behavior, global/instance/test-case level configuration, overriding behavior, and mixed scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
graphite-app
bot
deleted the
12-09-feat_linter_plugins_add_ignorenonfatalerrors_option_to_ruletester_
branch
Copilot AI
pushed a commit
that referenced
this pull request
Dec 10, 2025
…r` (#16672) Add an option to `RuleTester` to ignore non-fatal parsing errors. ```js const tester = new RuleTester({ languageOptions: { sourceType: "module", parserOptions: { ignoreNonFatalErrors: true, }, }, }); tester.run("my-rule", rule, { valid: [ // This is invalid code, but it gets a pass "function f(x, x) {}", ], invalid: [], }); ``` This will be useful in conformance tests, because ESLint's tests contain invalid syntax in many of their test cases!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to
RuleTesterto ignore non-fatal parsing errors.This will be useful in conformance tests, because ESLint's tests contain invalid syntax in many of their test cases!