feat(zk-verifier): per-note circuit versioning with version retirement#110
Merged
Conversation
Real measured weights for account-mapping, relayer, shielded-pool and zk-verifier. zk-verifier gains retire_version / unretire_version (retire ~20.96ms, unretire ~15.41ms — unretire only clears a flag); shielded-pool covers the circuit_version-carrying private_transfer / unshield / claim_shielded_fees.
Cut dated releases for the per-note circuit-version work: - orbinum-zk-verifier 1.2.0 → 1.3.0 (transfer arity fix) - pallet-zk-verifier 0.8.0 → 0.9.0 (version retirement, circuit-version verify, regenerated weights) - pallet-shielded-pool 0.8.3 → 0.9.0 (circuit_version params, regenerated weights) - pallet-evm-precompile-shielded-pool 0.2.0 → 0.3.0 (circuitVersion calldata) - pallet-account-mapping 0.3.1 → 0.3.2 (weights regenerated) - pallet-relayer 0.3.0 → 0.3.1 (weights regenerated)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verify each spend against the circuit version its note was created under, not merely the active one, so rotating a verification key never bricks notes minted under the old key. Plus the security hardening the rotation audit surfaced.
Consensus-affecting: dispatch signatures change and new extrinsics are added → spec_version and transaction_version bump.
zk-verifier pallet:
zk-verifier primitive:
shielded-pool pallet:
EVM precompile:
Runtime:
extrinsics (retire_version, unretire_version) were added, so both versions
bump for the per-note circuit-version release.