-
Notifications
You must be signed in to change notification settings - Fork 13
CNV-76072: Add success alert when creating another nncp through form #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
CNV-76072: Add success alert when creating another nncp through form #157
Conversation
|
@batyana: This pull request references CNV-76072 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
adamviktora
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I found out that if we let the alert disappear with timeout, then next time the alert is not shown. (it works fine if we manually close the alert)
Screen.Recording.2026-01-19.at.9.57.52.mov
Signed-off-by: batyana <[email protected]>
cf513f1 to
22f0d0c
Compare
|
@batyana: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: adamviktora, batyana The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |

in the create nnc wizard when checking the checkbox to create another it creates the nncp and navigates to the beginning of the wizard without any indication to the user that the nncp was created successfully. this pr adds a success alert.