Skip to content

Conversation

@batyana
Copy link

@batyana batyana commented Jan 18, 2026

in the create nnc wizard when checking the checkbox to create another it creates the nncp and navigates to the beginning of the wizard without any indication to the user that the nncp was created successfully. this pr adds a success alert.

Screenshot at Jan 18 12-19-25

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 18, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 18, 2026

@batyana: This pull request references CNV-76072 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

in the create nnc wizard when checking the checkbox to create another it creates the nncp and navigates to the beginning of the wizard without any indication to the user that the nncp was created successfully. this pr adds a success alert.

Screenshot at Jan 18 12-19-25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from metalice and pcbailey January 18, 2026 10:47
Copy link

@adamviktora adamviktora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I found out that if we let the alert disappear with timeout, then next time the alert is not shown. (it works fine if we manually close the alert)

Screen.Recording.2026-01-19.at.9.57.52.mov

@batyana batyana force-pushed the CNV-76072-Add-success-alert-to-wizard branch from cf513f1 to 22f0d0c Compare January 19, 2026 10:10
@openshift-ci
Copy link

openshift-ci bot commented Jan 19, 2026

@batyana: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2026
@openshift-ci
Copy link

openshift-ci bot commented Jan 19, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: adamviktora, batyana
Once this PR has been reviewed and has the lgtm label, please assign cybertron for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants