Skip to content

OCPBUGS-54901: Check for API server reachability before updating kubeconfig #10099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sadasu wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −1
Open

OCPBUGS-54901: Check for API server reachability before updating kubeconfig #10099

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion cmd/openshift-install/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,7 +538,6 @@ func handleUnreachableAPIServer(ctx context.Context, config *rest.Config) error
if !installConfig.Config.PublicAPI() {
lbType = lbconfig.PrivateLoadBalancer
}

_, ipAddrs, err := lbConfig.ParseDNSDataFromConfig(lbType)
if err != nil {
return fmt.Errorf("failed to parse lbconfig: %w", err)
Expand All @@ -553,6 +552,21 @@ func handleUnreachableAPIServer(ctx context.Context, config *rest.Config) error
return fmt.Errorf("no ip address found in lbconfig")
}

if !installConfig.Config.PublicAPI() {
// Check for LB IP reachability from Install host.
address := net.JoinHostPort(ipAddr, "6443")
conn, err := net.DialTimeout("tcp", address, time.Second*10)
if err != nil {
// Not reachable because install host is not in the cluster network.
// Use kubeconfig without dialer context because some reachability
// mechanism like a proxy/bastion host would be put in place to access
// the cluster.
logrus.Debugf("private install with userProvisionedDNS. Install host is not in the same network as the cluster. Not updating kubeconfig for cluster access.")
return nil
}
conn.Close()
}

dialer := &net.Dialer{
Timeout: 1 * time.Minute,
KeepAlive: 1 * time.Minute,
Expand Down