Clarify that 416 is valid on a blob put#593
Open
sudo-bmitch wants to merge 1 commit intoopencontainers:mainfrom
Open
Clarify that 416 is valid on a blob put#593sudo-bmitch wants to merge 1 commit intoopencontainers:mainfrom
sudo-bmitch wants to merge 1 commit intoopencontainers:mainfrom
Conversation
Signed-off-by: Brandon Mitchell <git@bmitch.net>
|
I'll publicly log my opinion that while I agree this is a valid response code, I disagree that it's a MUST, especially given backwards compatibility with existing registries in production today. I'd rather push to say that in chunked upload, the final put should not have data at all. |
Contributor
Author
I think removing support for data in the final chunk is a bigger than this PR. There is language supporting it on the previous lines of the spec that have been there for a while. Can we make that a separate issue/PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #590.