Add "inputs" support to pyCA #587
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for sending configuration to the agent configuration endpoint in Opencast. Adds a new config option "inputs". It allows users to specifiy for a given event which tracks they would like to show up in the final recording. For example, if the agent is capable of recording both "presenter/source" and "presentation/source", a user may select only "presentation/source" as input.
Arnei
force-pushed
the
extended-capture-agent-api
branch
from
ff96eb2 to
6626e4c
Compare
Member
Author
|
Test is failing because the minimum level of code coverage is not met. This is in part due to this PR adding code to a function that already was not covered by code tests previously, which in itselfs seems to be a bug. I could not quite figure out how to properly fix that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for sending configuration to the agent configuration endpoint in Opencast.
Adds a new config option "inputs". It allows users to specifiy for a given event which tracks they would like to show up in the final recording. For example, if the agent is capable of recording both "presenter/source" and "presentation/source", a user may select only "presentation/source" as input.
The idea behind this PR was to make a demo implementation for the extended capture agent api that is currently in the works in the main repo opencast/opencast#7114. However, pyCA cannot make use of any of the new properties/capabilities. So this just adds "inputs", which is a feature that already exists in Opencast and conversely this PR should work fine without opencast/opencast#7114.
This PR is very similar to #413, it just does less.