feat(windows) start powershell in utf-8 mode #7902
Open
+301
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylan-hurd-oai
force-pushed
the
dh--powershell--utf-8
branch
2 times, most recently
from
e5750bd to
a623f60
Compare
dylan-hurd-oai
force-pushed
the
dh--powershell--utf-8
branch
from
a623f60 to
e67b964
Compare
dylan-hurd-oai
changed the title
dylan-hurd-oai
force-pushed
the
dh--powershell--utf-8
branch
4 times, most recently
from
e2b078c to
2a24d64
Compare
dylan-hurd-oai
changed the title
dylan-hurd-oai
force-pushed
the
dh--powershell--utf-8
branch
2 times, most recently
from
ae69170 to
77f84e0
Compare
dylan-hurd-oai
force-pushed
the
dh--powershell--utf-8
branch
from
ff57428 to
072c7a6
Compare
jif-oai
reviewed
Dec 19, 2025
Collaborator
jif-oai
left a comment
jif-oai
left a comment
There was a problem hiding this comment.
Ok on the principle but a lot of the wiring can be simplified
| const POWERSHELL_FLAGS: &[&str] = &["-nologo", "-noprofile", "-command", "-c"]; | ||
|
|
||
| /// Prefixed command for powershell shell calls to force UTF-8 console output. | ||
| pub(crate) const UTF8_OUTPUT_PREFIX: &str = |
Collaborator
There was a problem hiding this comment.
TIL, I would never have guesses that this is sufficient.
|
|
||
| /// Prefixed command for powershell shell calls to force UTF-8 console output. | ||
| pub(crate) const UTF8_OUTPUT_PREFIX: &str = | ||
| "[Console]::OutputEncoding=[System.Text.Encoding]::UTF8;\n"; |
Collaborator
There was a problem hiding this comment.
Is it stable for every windows version?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a FeatureFlag to enforce UTF8 encoding in powershell, particularly Windows Powershell v5. This should help address issues like #7290.
Notably, this PR does not include the ability to parse
apply_patchinvocations within UTF8 shell commands (calls to the freeform tool should not be impacted). I am leaving this out of scope for now. We should address before this feature becomes Stable, but those cases are not the default behavior at this time so we're okay for experimentation phase. We should continue cleaning up theapply_patch::invocationlogic and then can handle it more cleanly.Testing