Skip to content

Conversation

@qkaiser
Copy link
Contributor

@qkaiser qkaiser commented May 13, 2023

Draft branch to establish a baseline for code quality and probably do some refactoring as mentioned in #75

@qkaiser qkaiser self-assigned this May 13, 2023
@qkaiser qkaiser marked this pull request as draft May 13, 2023 12:17
@tnias
Copy link

tnias commented Jun 19, 2023

Not sure if this is the correct place to comment on this, but this looks like a cleanup and I thought it might fit. :)

The pyproject.toml (or the setup.py before) is very vague with license = "GNU GPL".

I found the following indicators:

  • LICENSE file is GPL-3.0
  • ubireader/ubi/defines.py: GPL-2.0-or-later
  • ubireader/ubifs/defines.py: GPL-2.0 (without clarification for "-only" or "-or-later")
  • all other non-empty python files had a GPL-3.0-or-later header

@qkaiser
Copy link
Contributor Author

qkaiser commented Jun 20, 2023

@tnias makes sense, thanks for pointing it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants