[FIX] fix failure to detect models when CachedModel is missing #507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cammarosano
requested changes
Dec 10, 2025
Collaborator
cammarosano
left a comment
cammarosano
left a comment
There was a problem hiding this comment.
If this is a fix, then I suggest you include in the commit message what you are fixing...
(I suppose this function returns false when it should not, in case CachedModel is not there).
Which leads to my next question: do we really need to support branches that haven't rebased yet into master?
mmahrouss
force-pushed
the
alpha-ignore-cached-model-nonexistence-mdms
branch
from
865c25a to
2d5ed6b
Compare
mmahrouss
changed the title
mmahrouss
force-pushed
the
alpha-ignore-cached-model-nonexistence-mdms
branch
2 times, most recently
from
464ae72 to
1fe060c
Compare
CachedModel is not required to define Odoo models, so we should not fail to detect models if CachedModel is not found in the Odoo source code. Treat `Model` and `TransientModel` similarly. only exit if `BaseModel` does not exist.
mmahrouss
force-pushed
the
alpha-ignore-cached-model-nonexistence-mdms
branch
from
1fe060c to
893bc7c
Compare
cammarosano
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we added CachedModel for 19.1. All commit that target 19.1 that were not rebased on master after adding the CachedModel were failing because we were always returning false in test_symbol_is_model because we do not find CachedModel.
However, I think it is incorrect to return false anyway, when CachedModel does not exist. Because a model can inherit from models.Model, and be fine, even before CachedModel is needed, same with TransientModel.