[Data filter] Trim whitespace #7592
Open
+45
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
matho-odoo
changed the title
matho-odoo
force-pushed
the
master-filter-with-whitespace-matho
branch
from
1b52dee to
a52fd15
Compare
hokolomopo
reviewed
Dec 5, 2025
Contributor
hokolomopo
left a comment
hokolomopo
left a comment
There was a problem hiding this comment.
👋
The values shown in the filter menu are now correct, but the values actually filtered when selecting a trimmed value are not. You should apply the same normalization in the evaluation of filters 🙂
(also tests are missing)
matho-odoo
force-pushed
the
master-filter-with-whitespace-matho
branch
from
a52fd15 to
e48889f
Compare
anhe-odoo
reviewed
Dec 8, 2025
| const cellValues = cells.map((val) => val.cellValue); | ||
| const filterValues = filterValue?.filterType === "values" ? filterValue.hiddenValues : []; | ||
| const normalizedFilteredValues = new Set(filterValues.map(toLowerCase)); | ||
| const normalizedFilteredValues = new Set(filterValues.map(normalize)); |
Contributor
There was a problem hiding this comment.
Not sure about this, but maybe we can store the normalized values in filterValue.hiddenValues instead of applying the normalize function each time we reevaluate a filter ?
LucasLefevre
reviewed
Dec 9, 2025
| }; | ||
| setGrid(model, grid); | ||
| createTableWithFilter(model, "A1:A5"); | ||
| updateFilterCriterion(model, "A1", { |
Collaborator
There was a problem hiding this comment.
this test passes even without this updateFilterCriterion, so I'm not sure what's the point
[Data filter] Trim whitespace and don't bother of caps vs low case when filtering Changes done in the filters by values and by criterion Task:5375214
matho-odoo
force-pushed
the
master-filter-with-whitespace-matho
branch
from
e48889f to
953fc39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
[Data filter] Trim whitespace and don't bother of caps vs low case when filtering
Task: 5375214
review checklist