test(basics): adjust win_borders test after Nightly changes#2489
Closed
abeldekat wants to merge 1 commit into
Closed
test(basics): adjust win_borders test after Nightly changes#2489abeldekat wants to merge 1 commit into
win_borders test after Nightly changes#2489abeldekat wants to merge 1 commit into
Conversation
Details: - The order of the fields in the resulting `vim.o.fillchars` now is the same as in the `H.win_borders_fillchars` definitions. - See PR 39849 in neovim/neovim.
abeldekat
force-pushed
the
test_fix_basics
branch
from
9f35dde to
271dc2b
Compare
echasnovski
added a commit
that referenced
this pull request
Jun 29, 2026
Details: - Order of entries in 'fillchar' does not matter, but using alphabetical one makes it more robust across Neovim versions (Neovim>=0.13 preserves actual order of entries). Resolve #2489
echasnovski
added a commit
that referenced
this pull request
Jun 29, 2026
Details: - Order of entries in 'fillchar' does not matter, but using alphabetical one makes it more robust across Neovim versions (Neovim>=0.13 preserves actual order of entries). Resolve #2489
Member
|
Thanks for the PR! I was about to merge into |
Member
Author
|
That's completely fine. Thanks for the feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details:
vim.o.fillcharsnow is the same as in theH.win_borders_fillcharsdefinitions.