Fix Ruby 4.0 compatibility: replace deprecated CGI.parse#453
Merged
kangkyu merged 1 commit intonullscreen:masterfrom Jan 8, 2026
Merged
Fix Ruby 4.0 compatibility: replace deprecated CGI.parse#453kangkyu merged 1 commit intonullscreen:masterfrom
kangkyu merged 1 commit intonullscreen:masterfrom
Conversation
….0 compatibility Ruby 4.0 removed CGI.parse from the standard library. Use URI.decode_www_form instead, which is part of the core URI library and provides identical functionality.
Contributor
|
Thank you for contributing |
kangkyu
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CGI.parsewithURI.decode_www_forminResumableSessionrequire 'cgi'Context
Ruby 4.0 removed the
cgilibrary from the standard library. Onlycgi/escaperemains available for basic escaping methods. This causes the following error when uploading videos: undefined method 'parse' for class CGISolution
Use
URI.decode_www_formwhich is part of Ruby's coreURIlibrary and provides identical functionality. This is the recommended replacement per Ruby documentation.Before:
After:
Testing
This change is backwards compatible with Ruby 3.x as URI.decode_www_form has been available since Ruby 1.9.2.